Skip to main content

Submitting Pull Requests

Creating A Pull Request​

Apache Curator uses the Git version control system.

Curator also uses Apache's GitHub mirroring. All source code/bug fix submissions should be made via GitHub Pull Request.

Create your Pull Request against the latest revision of the files by forking the mirrored project at https://github.com/apache/curator (keep your fork in sync from then on).

You must also create an issue in Curator's Issue Tracker (reference the Pull Request in the issue) and create a git branch with the same name as the Issue. All discussion, comments, etc. regarding the Pull Request should be in the Issue Tracker and/or GitHub and not by email.

  • Fork the Curator project from GitHub
  • Create a branch with the same name as the JIRA Issue number (e.g. CURATOR-1234) in your fork and push it to GitHub
  • Create a Pull Request in GitHub. The name of the Pull Request should be in the form: [CURATOR-XXX] Summary of the Issue
  • The Apache infrastructure tools will automatically add a reference to your PR in the JIRA Issue

Apache Contribution Guide​

Please read the Apache Contribution Guide.

Tools and Libraries​

Curator uses the following tools and libraries:

Style and Development Guide​

  • Use spaces not tabs.
  • Match the style of the Curator files. Any patches will be re-formatted to match Curator style.
  • There must be a JIRA Issue created for your change.
  • Create a git branch with the same name as the Issue.
  • All submissions must have TestNG tests.
  • All submissions must have proper Apache license headers. Run the following command to make sure all files have headers: docker run --rm -v $(pwd):/github/workspace ghcr.io/korandoru/hawkeye-native:v3 format.
  • The simpler and smaller the change the more likely it is to be accepted.